Re: [PATCH] x86: add apic probe for genapic 64bit v2

[Mike Travis]

Yinghai Lu wrote:
> On Tue, Jul 22, 2008 at 12:13 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
>> * Ingo Molnar <mingo@xxxxxxx> wrote:
>>
>>>> v2: fix compiling when CONFIG_ACPI is not set
>>> applied to tip/x86/x2apic - thanks Yinghai.
>>>
>>>> +static struct genapic *apic_probe[] __initdata = {
>>>> +   &apic_x2apic_uv_x,
>>>> +   &apic_x2apic_phys,
>>>> +   &apic_x2apic_cluster,
>>>> +   &apic_physflat,
>>>> +   NULL,
>>>> +};
>>> very nice generalization!
>> btw.:
>>
>>   apic_probe[i]->acpi_madt_oem_check
>>
>> should probably be renamed to something more neutral like "->probe" -
>> there's nothing ACPI about it and some weird boxes could use PCI or
>> other probing mechanisms to discover the type of APIC they want to use.
> 
> 32bit has acpi_madt_oem_check and mps_oem_check
> 64bit should only have acpi_madt_oem_check
> 
>> plus i guess genapic_32.h and genapic_64.h should be unified and struct
>> apic_ops should be put into struct genapic?
> 
> yes.
> 
> hope to call acpi_madt_oem_check and mps_oem_check right after
> acpi_boot_table_init
> to decide apic_ops and genapic as early as possible.
> 
> 
> Jack/Mike,
> does your big box support SRAT? it seems it calling is_uv_system
> before acpi_madt_oem_check is called.
> I like to call early_acpi_boot_init, before acpi_numa_init so
> acpi_madt_oem_check is called before srat is used. can you check
> attached patch on your system?
> 
> YH
> 

Hi,

Yes, I believe so though the final BIOS is not yet complete.

Next chance I get, I'll try out your patch.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/