Re: [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver

[Dan Williams]

On Fri, Jul 18, 2008 at 2:51 PM, Brice Goglin <Brice.Goglin@xxxxxxxx> wrote:
> Dan Williams wrote:
>>>> Sleep time in self_test has been increased to 10ms
>>>> since in some cases 1ms appeared not to be enough
>>> Thanks Maciej, this helps a lot here.
>>>
>>
>> Can I interpret this as a "Tested-by" for the watchdog and/or the self_test fix?
>
> The sleep time increase to 10ms has been tested for a while (and helps a
> lot here).
>

On my system I can still occasionally reproduce the self-test failure
with this longer timeout.  I think we should hold off on this band-aid
patch until the root cause is found.  We can get this fix in after the
merge window closes.

> I don't know about the watchdog yet.

This one has been observed to fix the hang condition so I will include
it in my upcoming pull request.  Holler if your testing proves
otherwise.

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/