Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)

[Andrew Morton]

On Thu, 12 Jun 2008 11:53:36 -0700
David Brownell <david-b@xxxxxxxxxxx> wrote:

> This adds a simple sysfs interface for GPIOs.

device_create_drvdata() has magically vanished from today's linux-next,
so this code doesn't compile any more.

This:

--- a/drivers/gpio/gpiolib.c~gpio-sysfs-interface-updated-gpio-linux-next-fixes-for-sysfs-support-fix
+++ a/drivers/gpio/gpiolib.c
@@ -453,8 +453,8 @@ int gpio_export(unsigned gpio, bool dire
 	if (status == 0) {
 		struct device	*dev;
 
-		dev = device_create_drvdata(&gpio_class, desc->chip->dev, 0,
-				desc, "gpio%d", gpio);
+		dev = device_create(&gpio_class, desc->chip->dev, 0, desc,
+					"gpio%d", gpio);
 		if (dev) {
 			if (direction_may_change)
 				status = sysfs_create_group(&dev->kobj,
@@ -537,8 +537,8 @@ static int gpiochip_export(struct gpio_c
 
 	/* use chip->base for the ID; it's already known to be unique */
 	mutex_lock(&sysfs_lock);
-	dev = device_create_drvdata(&gpio_class, chip->dev, 0, chip,
-			"gpiochip%d", chip->base);
+	dev = device_create(&gpio_class, chip->dev, 0, chip, "gpiochip%d",
+				chip->base);
 	if (dev) {
 		status = sysfs_create_group(&dev->kobj,
 				&gpiochip_attr_group);
_

seems to compile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/