Re: [PATCH 11/24] x86/oprofile: Add IBS support for AMD CPUs, modelspecific code

[Maynard Johnson]

Robert Richter wrote:
> From: Barry Kasindorf <barry.kasindorf@xxxxxxx>
>
> This patchset supports the new profiling hardware available in the
> latest AMD CPUs in the oProfile driver.
>
> Signed-off-by: Barry Kasindorf <barry.kasindorf@xxxxxxx>
> Signed-off-by: Robert Richter <robert.richter@xxxxxxx>
> ---
>  arch/x86/oprofile/op_model_athlon.c |  257 +++++++++++++++++++++++++++++++++++
>  1 files changed, 257 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/oprofile/op_model_athlon.c b/arch/x86/oprofile/op_model_athlon.c
> index 40ecb02..229e0b4 100644
> --- a/arch/x86/oprofile/op_model_athlon.c
> +++ b/arch/x86/oprofile/op_model_athlon.c
> @@ -9,9 +9,13 @@
>   * @author Philippe Elie
>   * @author Graydon Hoare
>   * @author Robert Richter <robert.richter@xxxxxxx>
> + * @author Barry Kasindorf
>  */
[snip]
> +
> +struct op_ibs_config {
> +	unsigned long op_enabled;
> +	unsigned long fetch_enabled;
> +	unsigned long max_cnt_fetch;
> +	unsigned long max_cnt_op;
> +	unsigned long rand_en;
> +	unsigned long dispatched_ops;
I don't see dispatched_ops being used either by your kernel driver changes or by 
the userspace changes submitted by Jason.

-Maynard
[snip]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/