Re: [PATCH 1/2] ftrace: single CPU tracers use CPU clock

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> > this is not a good idea. We want to fix cpu_clock(), not work around 
> > any deficiencies it might have.
> 
> cpu_clock currently is "sched_clock" when the 
> CONFIG_HAVE_UNSTABLE_SCHED_CLOCK is not set. Which is done via 
> configuration, and I noticed is set on my boxes with a stable TSC??

define 'stable TSC' ;-)

> Perhaps we need to make cpu_clock change dynamically when an unstable 
> sched_clock is detected.
> 
> Even in this case, forcing the tracers that are single CPU to use a 
> clock source that modifies itself to try to look stable across CPUs 
> still seems wrong to me.  The goal of looking stable across CPUs will 
> always be at odds with the irqsoff tracer that does not care about 
> other CPUS but cares tremendously about accurate latencies.

other tracers care too - for example to have the right chronology of 
trace events. The scheduler cares too. What kind of worst-case cross-CPU 
effects have you observed?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/