Re: [patch 2.6.26-git] /dev/hpet - fixes and cleanup

[Clemens Ladisch]

David Brownell wrote:
> Oh ... I see.  It's called write_counter() but doesn't
> actually write the counter.  Likewise, read_counter() is
> not actually reading the counter.  Gaack ...

A more correct name would be something like
write_a_register_that_has_the_same_size_as_a_counter_register().

> In fact, most places would be better off just hard-wiring 32-bit
> access...

... and the definition of read/write_counter() depends on the word size
of the CPU architecture and has nothing to do with the actual size of
the HPET registers ...

I'm hoping that I can deprecate and delete much of this code without
having to clean it up first.

> Any comments on the rest?

Looks fine.  I would have preferred a series of smaller patches, but my
feelings on this are not strong enough to split it myself or to ask you
to do it.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/