Re: [PATCH] fix misalignment in pxamci

[Uli Luckas]

On Saturday, 5. July 2008, pHilipp Zabel wrote:
> On Sat, Jul 5, 2008 at 2:19 AM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
> > Hi,
> > Philipp Zabel finally made the pxamci issue clear. It turned out, that
> > pxamci needs the DMA destination address to be aligned to 8 bytes. In
> > some cases it happened, that the address was aligned to 4 bytes causing
> > controller to incorrectly transfer data (and resulting into error like
> > "mmc0: unrecognised SCR structure version 1"). The following patch allows
> > to debug this issue and moreover fixes it by moving one 4 byte entry of
> > mmc_card structure, aligning the DMA destination back to 8 bytes.
> >
> > Signed-off-by: Marek Vasut <marek.vasut@xxxxxxxxx>
>
> We can enable byte aligned transfers on the DMA controller. This is
> what I came up with yesterday:
> (sorry for wrapped lines - the proper patch should probably be a
> combination of both
> warning/DALGN handling and and moving something in mmc_card around).
>
Hi Philipp,
this driver is not only for pxa27x but for pxa25x as well and pxa25x can't 
handle unaligned DMA.
Shouldn't Marek Vasut's patch be included for the PXA25x case?

regards,
Uli


-- 

------- ROAD ...the handyPC Company - - -  ) ) )

Uli Luckas
Software Development

ROAD GmbH
Bennigsenstr. 14 | 12159 Berlin | Germany
fon: +49 (30) 230069 - 64 | fax: +49 (30) 230069 - 69
url: www.road.de

Amtsgericht Charlottenburg: HRB 96688 B
Managing directors: Hans-Peter Constien, Hubertus von Streit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/