Re: GRU driver feedback

From: Jack Steiner
Date: Mon Jul 28 2008 - 13:44:54 EST



Whoops:

>
> - In gru_fault, I don't think you've validated the size of the vma, and it
> definitely seems like you haven't taken offset into the vma into account
> either. remap_pfn_range etc should probably validate the former because I'm
> sure this isn't the only driver that might get it wrong. The latter can't
> really be detected though. Please fix or make it more obviously correct (eg
> a comment).

ZZZ
s/ZZZ/fixed/



--- jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/