Re: [PATCH] FILESYSTEMS: Make "advanced partitions" immediatelyunselectable.

[Robert P. J. Day]

On Mon, 28 Jul 2008, Randy Dunlap wrote:

> On Mon, 28 Jul 2008 14:42:47 -0400 (EDT) Robert P. J. Day wrote:
>
> > On Mon, 28 Jul 2008, Randy Dunlap wrote:
> >
> > > >   yes, it's nitpicking but, as it's laid out right now, it's
> > > > unnecessarily confusing and inconsistent.  but i don't know if
> > > > there's a trivial fix for it.
> > >
> > > Yes, I'd call MSDOS partitions basic, not Advanced, and then put all
> > > others under an Advanced menu that can be toggled on/off easily with
> > > menuconfig.
> > >
> > > Not quite trivial, but not messy either.
> > >
> > > Patch below.  Comments?
> >
> > ... patch snipped ...
> >
> >   i suspect that's as good as it's going to get, but it's
> > unfortunate that it adds yet another level of submenu under
> > "Partition types."
>
> I looked but didn't see a way to avoid that.

  upon further consideration, i don't either, so i'm happy with it.
the only thing i might add is some actual help text for that
MSDOS_PARTITION option -- something more informative than "Say Y
here."  perhaps a sentence explaining *why* people might want to say
"Y" there?  or the rare circumstances under which they wouldn't?  just
a thought.

  other than that, it looks good.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/