Re: drivers/sh/maple/maple.c compile error

[Adrian McMenamin]

On Tue, 2008-07-29 at 05:44 +0900, Paul Mundt wrote:
> On Mon, Jul 28, 2008 at 11:20:12PM +0300, Adrian Bunk wrote:
> > Commit 306cfd630a4d121cf4e08b894d8b4c4cf106e57e
> > (maple: tidy maple_driver code by removing redundant connect/disconnect)
> > causes the following compile error:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      drivers/sh/maple/maple.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c: In function 'attach_matching_maple_driver':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c:259: error: 'struct maple_driver' has no member named 'connect'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c: In function 'maple_detach_driver':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c:272: error: 'struct maple_driver' has no member named 'disconnect'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c:273: error: 'struct maple_driver' has no member named 'disconnect'
> > make[4]: *** [drivers/sh/maple/maple.o] Error 1
> > 
> > <--  snip  -->
> > 
> Adrian was supposed to send follow-up patches for this, which never
> happened. I thought I had dropped this already, but in this case I'll
> just revert it.

Actually I wasn't asked about this, but to submit a fix/replacement for
a patch that didn't apply.

I will submit a patch for the whole thing then - as I cannot actually
match the commit Adrian has quoted to anything.

I think the problem is that I am trying to get a change in the bus and
in the drivers (which have different maintainers) to go in together and
that has never quite worked. The code runs fine on my box and has done
for months now.

Adrian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/