Re: [PATCH] Oprofile Multiplexing Patch

[Robert Richter]

On 26.07.08 13:16:26, Ingo Molnar wrote:
> 
> > From: Jason Yeh <jason.yeh@xxxxxxx>
> 
> > diff --git a/arch/x86/oprofile/op_model_p4.c b/arch/x86/oprofile/op_model_p4.c
> > index 56b4757..e641545 100644
> > --- a/arch/x86/oprofile/op_model_p4.c
> > +++ b/arch/x86/oprofile/op_model_p4.c
> > @@ -701,6 +701,8 @@ static void p4_shutdown(struct op_msrs const * const msrs)
> >  struct op_x86_model_spec const op_p4_ht2_spec = {
> >  	.num_counters = NUM_COUNTERS_HT2,
> >  	.num_controls = NUM_CONTROLS_HT2,
> > +	.num_hardware_counters = NUM_COUNTERS_HT2,
> > +	.num_hardware_controls = NUM_CONTROLS_HT2,
> 
> is there any further change needed for Intel CPUs to benefit from 
> multiplexing too, up to the max of 32 controls? (AFAICS it should work 
> as-is, correct?)

I would like to wait with this change until the code base is
stable. There could be some follow-up changes that would require more
rework then.

-Robert

> 
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/