Re: [patch v3] splice: fix race with page invalidation

[Linus Torvalds]

On Wed, 30 Jul 2008, Miklos Szeredi wrote:
> 
> There are no real disadvantages: splice() from a file was originally meant to
> be asynchronous, but in reality it only did that for non-readahead pages,
> which happen rarely.

I still don't like this. I still don't see the point, and I still think 
there is something fundamentally wrong elsewhere.

I also object to just dismissing the async nature as unimportant. Fix it 
instead. Make it use generic_file_readahead() or something. This is fixing 
things in all the wrong places, imnsho.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/