Re: [PATCH] mISDN cleanup user interface

[Sam Ravnborg]

On Wed, Jul 30, 2008 at 07:51:38PM +0200, Karsten Keil wrote:
> On Wed, Jul 30, 2008 at 05:57:01PM +0100, David Woodhouse wrote:
> > On Wed, 2008-07-30 at 18:33 +0200, Karsten Keil wrote:
> > > What about this implementation ?
> > 
> > Looks a lot saner... although it does seem to confirm my earlier
> > suspicion that you're not even _using_ the fact that it's a bitmap at
> > all. You set the bits for the present channels at init time, which are
> > always contiguous, and you never seem to change them them later -- why
> > couldn't you do this with a simple 'number of channels' integer?
> 
> No it is not contineous on different PRI line setups (E1,T1 ...)
> e.g a E1 has the D-channel on channel 15 position, so this bit is not set
> then.
timeslot 16 in my book actually - but maybe that your timeslot to
channel mapping.

Not that it has anything to do with the topic discussed!

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/