Re: commit a29ccf6f823a84d89e1c7aaaf221cf7282022024 break console on slackware 12.1

[Grant Coady]

On Wed, 30 Jul 2008 13:11:50 -0700, Tim Bird <tim.bird@xxxxxxxxxxx> wrote:

>Grant Coady wrote:
>> I have the same issue, the line drawing characters are displayed as an odd 
>> looking C with a tail.  Slackware-12.1 and Slamd64-12.1.
>> 
>> .configs:
>>   http://bugsplatter.mine.nu/test/boxen/pooh/config-2.6.27-rc1a.gz
>>   http://bugsplatter.mine.nu/test/boxen/pooh64/config-2.6.27-rc1a.gz
>> 
>> CONFIG_CONSOLE_TRANSLATIONS=y ?? yes it's on
>
>This looks like an operator precedence bug introduced by
>the patch.
>
>Normally I would test this myself before sending it out, but
>I can't test 2.6.27-rc1 right now on my hardware due to another
>bug in the 2.6.27-rc1 tree.
>
>Can you please try the following patch and let me know if that
>fixes the problem?

Hi Tim,
Yep, this patch fixes the issue.  Tested on slackware-12.1 with the 
default lilo option '#append=" vt.default_utf8=0"' commented out.

Grant.

>
>Thanks,
> -- Tim
>
>diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
>index 14c0e91..8c8119f 100644
>--- a/include/linux/vt_kern.h
>+++ b/include/linux/vt_kern.h
>@@ -74,7 +74,7 @@ void con_protect_unimap(struct vc_data *vc, int rdonly);
> int con_copy_unimap(struct vc_data *dst_vc, struct vc_data *src_vc);
>
> #define vc_translate(vc, c) ((vc)->vc_translate[(c) |			\
>-					(vc)->vc_toggle_meta ? 0x80 : 0])
>+					((vc)->vc_toggle_meta ? 0x80 : 0)])
> #else
> #define con_set_trans_old(arg) (0)
> #define con_get_trans_old(arg) (-EINVAL)
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/