Re: linux-next: Tree for July 30

From: Dmitry Torokhov
Date: Thu Jul 31 2008 - 16:40:12 EST


On Thu, Jul 31, 2008 at 01:28:37PM -0700, Linus Torvalds wrote:
>
> + /* Some people get confused about size in bits vs bytes */
> + if (size >= len/8)
> + size = size/8;

People usually allocate single buffer (big enough) and the do a bunch
of tests so this condiion is likely to fire on EV_SW and similar event
types. I think it is safer to explicitely test for EV_KEY/0x1ff.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/