Re: [PATCH] stack and rcu interaction bug in smp_call_function_mask()

From: Jeremy Fitzhardinge
Date: Mon Aug 11 2008 - 00:27:22 EST


Nick Piggin wrote:
Nice debugging work.

I'd suggest something like the attached (untested) patch as the simple
fix for now.

I expect the benefits from the less synchronized, multiple-in-flight-data
global queue will still outweigh the costs of dynamic allocations. But
if worst comes to worst then we just go back to a globally synchronous
one-at-a-time implementation, but that would be pretty sad!

What if we went the other way and strictly used queue-per-cpu? It means multicast would require multiple enqueueing operations, which is a bit heavy, but it does make dequeuing and lifetime management very simple...

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/