Re: [PATCH] x86_64: remove empty lines from stack traces/oopses

[Alexey Dobriyan]

On Mon, Aug 11, 2008 at 07:02:19PM +0200, Ingo Molnar wrote:
> * Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> 
> >  show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
> >  		unsigned long *stack, unsigned long bp, char *log_lvl)
> >  {
> > -	printk("\nCall Trace:\n");
> > +	printk("Call Trace:\n");
> >  	dump_trace(task, regs, stack, bp, &print_trace_ops, log_lvl);
> > -	printk("\n");
> >  }
> 
> hm, it's nice to have stack traces stand out a bit, and to not get the 
> 'Call Trace' embedded in the middle of a printk (which happens to crash 
> or produce a stack dump).

Sometimes all you have is 80x25 or just screenshot from some stupid windows
monitoring program.

> >  void show_trace(struct task_struct *task, struct pt_regs *regs,
> > @@ -386,6 +385,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
> >  		printk(" %016lx", *stack++);
> >  		touch_nmi_watchdog();
> >  	}
> > +	printk("\n");
> >  	show_trace_log_lvl(task, regs, sp, bp, log_lvl);
> >  }
> >  
> > @@ -443,7 +443,6 @@ void show_registers(struct pt_regs *regs)
> >  		printk("Stack: ");
> >  		show_stack_log_lvl(NULL, regs, (unsigned long *)sp,
> >  				regs->bp, "");
> > -		printk("\n");
> >  
> >  		printk(KERN_EMERG "Code: ");
> 
> just to make sure i get the gist of your change, do you have a 'before' 
> and 'after' sample oops, so that we can see the difference?

Any recent oops with and without empty lines after Call trace: and
after calltrace.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/