Re: [2.6 patch] uninline atl1e_setup_mac_ctrl()

[Jeff Garzik]

Adrian Bunk wrote:
> There doesn't seem to be a compelling reason why atl1e_setup_mac_ctrl() 
> is marked as "inline":
>
> It's not used in any place where speed would matter much, and as long as 
> it has only one caller non-ancient gcc versions anyway inline it 
> automatically.
>
> This patch fixes the following compile error with gcc 3.4:
>
> <--  snip  -->
>
> ...
>   CC      drivers/net/atl1e/atl1e_main.o
> atl1e_main.c: In function `atl1e_check_link':
> atl1e_main.c:50: sorry, unimplemented: inlining failed in call to 
> atl1e_main.c:196: sorry, unimplemented: called from here
> make[4]: *** [drivers/net/atl1e/atl1e_main.o] Error 1
>
> <--  snip  -->
>
> Reported-by: Adrian Bunk <bunk@xxxxxxxxxx>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/