Re: [PATCH v2 3/6] ftrace: enable mcount recording for modules
From: Steven Rostedt
Date: Thu Aug 14 2008 - 19:41:45 EST
Rusty Russell wrote:
On Friday 15 August 2008 05:45:09 Steven Rostedt wrote:
This patch enables the loading of the __mcount_section of modules and
changing all the callers of mcount into nops.
...
+ if (mcountindex) {
+ void *mseg = (void *)sechdrs[mcountindex].sh_addr;
+ ftrace_init_module(mseg, mseg + sechdrs[mcountindex].sh_size);
You don't actually need the if. The size of section 0 is 0.
Thanks,
But I find the if is a bit more clear. It may confuse code reviewers if
we expect them to know that sechdrs[0].sh_size is zero. This isn't a hot
path.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/