Re: [PATCH 2.6.27-rc3 19/28] mdb: adding notify_die handler for keyboard debugger entry

[Andi Kleen]

jmerkey@xxxxxxxxxxxxxxxxxxxxx writes:
 
> +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE)
> +	if (down && !rep && keycode == KEY_PAUSE)
> +        {
> +	   if (notify_die(DIE_KERNELDEBUG, NULL, get_irq_regs(),
> +                          0, -1, SIGINT) == NOTIFY_STOP)
> +	      return;
> +	}
> +#endif
> +
>  #ifdef CONFIG_MAGIC_SYSRQ	       /* Handle the SysRq Hack */
>  	if (keycode == KEY_SYSRQ && (sysrq_down || (down == 1 && sysrq_alt))) {
>  		if (!sysrq_down) {

A nicer alternative to adding an hook here would be to use 
register_sysrq_key() to register a sysrq key that triggers
the debugger.  That function is also already exported.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/