Re: [PATCH 2/6] x86: apic - unify lapic_resume

From: Arjan van de Ven
Date: Sat Aug 16 2008 - 16:00:36 EST


On Sat, 16 Aug 2008 20:52:07 +0100 (BST)
"Maciej W. Rozycki" <macro@xxxxxxxxxxxxxx> wrote:

> On Sat, 16 Aug 2008, Cyrill Gorcunov wrote:
>
> > +#ifdef CONFIG_X86_64
> > + if (x2apic)
> > + enable_x2apic();
> > + else
> > +#endif
>
> Hmm, x86-64 hardware can run a 32-bit kernel, so it might be a good
> idea to take the opportunity of the merge and extend x2APIC support
> to the 32-bit configuration too. It should be mostly a mechanical
> change. Just a suggestion though -- feel free to ignore if you'd
> rather not dive into it. ;)

it's not like you can/want to go over 128 cpus on a 32 bit kernel
though..
--
If you want to reach me at my work email, use arjan@xxxxxxxxxxxxxxx
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/