Re: [patch 1/3] kmsg: Kernel message catalog macros.

From: Tim Hockin
Date: Sat Aug 16 2008 - 16:48:35 EST


On Sat, Aug 16, 2008 at 10:49 AM, Martin Schwidefsky
<schwidefsky@xxxxxxxxxx> wrote:

>> > > Can you hash the format string to generate the id? 6 hex digits should
>> > > be enough, and your tool can check for clashes. As it's bad form to have
>> > > identical strings for different semantics anyway, this seems to make
>> > > sense.

> Ok, so a specialized version of printk will do the work to calculate
> the hash. Only, what will we do if there ever is a conflict? The message
> tag has to be unique. The shorter the hash is, the more likely a
> collision gets. Don't know if 6 hash digits is enough to just ignore the
> problem.

And if you ever need to change the text that is in the format string?
The hash changes. That seems exactly counter to your goal...

Tim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/