Re: [PATCH 2/2] Add Dell laptop driver

[Matthew Garrett]

On Sat, Aug 16, 2008 at 07:17:05PM -0400, Parag Warudkar wrote:
> > +	da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
> > +			     sizeof(struct calling_interface_token),
> > +			     GFP_KERNEL);
> 
> Isn't a NULL check required here?

To the extent that it would result in this failing gracefully before 
some other part of the kernel becomes hideously upset, sure. I have a 
hard time caring, but I can easily fix it if other people do :)

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/