Re: [PATCH] kbuild: Fix creation of include2/asm symlink

From: Sam Ravnborg
Date: Sun Aug 17 2008 - 14:37:34 EST


On Sat, Aug 16, 2008 at 11:03:51AM +0200, Takashi Iwai wrote:
> At Fri, 15 Aug 2008 21:49:54 +0200,
> Sam Ravnborg wrote:
> >
> > On Fri, Aug 15, 2008 at 03:45:58PM +0200, Takashi Iwai wrote:
> > > The directory include2/asm can point wrongly to a non-existing
> > > directory on architectures that have moved include/asm under arch/*.
> > >
> > > This patch fixes it by checking firstly whether arch/*/include/asm is
> > > available.
> >
> > Hi Takashi.
> >
> > I understand why you try to avoid include2/asm as it is not pretty.
> > And I had a similar patch once - but I dropped it as the symlink do
> > not harm and it will anyway be gone when the remaining architectures
> > has shifted to use arch/$ARCH/include/...
> >
> > So I will not apply it.
>
> Hm, OK. Originally I fixed it because our build system has a sanity
> check against bogus symlinks and refused to package the latest kernel.
> If you don't want to put it in, we can keep it locally, of course.
> But, a bogus symlink is definitely not pretty...

It will go away as soon as all architextures are moved to use arch/$ARCH/include

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/