Re: linux-next: Tree for August 14 (sysfs/acpi errors)

From: Greg KH
Date: Sun Aug 17 2008 - 23:52:29 EST


On Sun, Aug 17, 2008 at 05:53:07AM +0200, Andi Kleen wrote:
> Greg KH <greg@xxxxxxxxx> writes:
> >> No!
> >
> > What you are doing here is wrong, trying to create two files with the
> > same name. You just should not be doing that at all, it's that simple.
> > Fix the broken code/link order, don't paper it over in the sysfs layer.
>
> Sorry, but relying on link order for anything is a mistake. It is subtle
> and fragile and just means it'll eventually break again because it's
> near impossible to properly maintain.

We rely on link order for all sorts of things, this isn't new at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/