Re: [PATCH] Fix i486 suspend to disk CR4 oops

From: Andi Kleen
Date: Mon Aug 18 2008 - 02:41:15 EST


On Sun, Aug 17, 2008 at 11:34:50PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >>>
> >>The other alternative is to probe for the CPUID instruction (via
> >>EFLAGS.ID) -- CR4 is present if and only if CPUID exists.
> >
> >Can be already checked for with boot_cpu_data.extended_cpuid_level.
> >
>
> I believe you mean just plain cpuid_level (which is set to -1 if CPUID
> doesn't exist.) extended_cpuid_level is only defined on x86-64, but all
> x86-64 CPUs have CR4.

Yes I meant plain cpuid_level. Just wanted to mention that before someone
opencodes another cpuid test.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/