Re: [PATCH] Fix i486 suspend to disk CR4 oops

[Ingo Molnar]

On Mon, Aug 18, 2008 at 05:14:50AM +0100, Maciej W. Rozycki wrote:
> On Sun, 17 Aug 2008, David Fries wrote:
> > +	/* cr4 was introduced in the Pentium CPU */
> 
>  NACK.  Later i486 chips do have CR4 -- for PSE, VME, etc. (the set of 
> features varies across the line).  Use a fixup as elsewhere or 
> something.

the version i committed (reproduced below) should work fine. It uses cr4 
opportunistically (we get a fault if it does not exist), and we write it 
back if the cr4 value is non-zero. (which it must always be on a 
CR4-enabled processor)

agreed?

	Ingo

----------->