Re: [PATCH 2/2] acpi_pm.c: check for monotonicity

From: Andreas Mohr
Date: Mon Aug 18 2008 - 16:18:56 EST


Hi,

On Mon, Aug 18, 2008 at 10:11:15PM +0200, Dominik Brodowski wrote:
> + if (good != 10) {
> + printk(KERN_INFO "PM-Timer had no reasonable result:"
> + " 0x%#llx - aborting.\n", value1);
> + return -ENODEV;
> }
> - printk(KERN_INFO "PM-Timer had no reasonable result:"
> - " 0x%#llx - aborting.\n", value1);
> - return -ENODEV;

Technically spoken this log message could now be considered partially
outdated... (we're doing 10 evaluations after all, not one with a
precise end result).


Seeing a define for those several open-coded 10 loops values would be nice.

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/