Re: [PATCH 1/3] Char: cyclades, remove bogus iomap

[Alan Cox]

On Mon, 18 Aug 2008 14:44:38 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, 14 Aug 2008 18:25:52 +0200
> Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> 
> > readl/writel are not expected to accept iomap return value. Replace
> > bogus mapping by standard ioremap.
> 
> Confused.  What's wrong with doing readl(pci_iomap(...))?  There are a
> fair number of drivers doing this..

That was discussed some time ago and we fixed a few then.

There is no guarantee that a platform chooses to implement iomaps such
that an iomap cookie is valid for readl/writel. It happens to work on the
current generic implementation.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/