Re: [PATCH] RADEON: duplicate PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb

From: Benjamin Herrenschmidt
Date: Mon Aug 18 2008 - 18:07:00 EST


On Mon, 2008-08-18 at 23:07 -0400, roel kluin wrote:
> untested, is it correct?
> ---
> duplicate PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb

Hard to say... this code originates from ATI. I'll have to dig a bit
to see what is the right bit combo I suppose.

> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/drivers/video/aty/radeon_pm.c b/drivers/video/aty/radeon_pm.c
> index 675abda..74d2e65 100644
> --- a/drivers/video/aty/radeon_pm.c
> +++ b/drivers/video/aty/radeon_pm.c
> @@ -210,7 +210,7 @@ static void radeon_pm_disable_dynamic_mode(struct radeonfb_info *rinfo)
> PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> - PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> + PIXCLKS_CNTL__R300_P2G2CLK_DAC_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_DISP_DAC_PIXCLK_DAC2_BLANK_OFF);
> OUTPLL(pllPIXCLKS_CNTL, tmp);
>
> @@ -392,7 +392,7 @@ static void radeon_pm_enable_dynamic_mode(struct radeonfb_info *rinfo)
> PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> - PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb);
> + PIXCLKS_CNTL__R300_P2G2CLK_DAC_ALWAYS_ONb);
> OUTPLL(pllPIXCLKS_CNTL, tmp);
>
> tmp = INPLL(pllMCLK_MISC);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/