Re: [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'

From: Yinghai Lu
Date: Mon Aug 18 2008 - 21:36:45 EST


On Mon, Aug 18, 2008 at 2:38 PM, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> Alex Nixon wrote:
>> From: Alex Nixon <alex.nixon@xxxxxxxxxx>
>> Date: Mon, 18 Aug 2008 12:56:48 +0100
>> Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'
>>
>> Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq.
>>
>> This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64.
>>
>
> Thanks Alex.
>
> Ingo, please apply.
>
> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>
>> Signed-off-by: Alex Nixon <alex.nixon@xxxxxxxxxx>
>> ---
>> arch/x86/xen/irq.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c
>> index 28b85ab..bb04260 100644
>> --- a/arch/x86/xen/irq.c
>> +++ b/arch/x86/xen/irq.c
>> @@ -21,7 +21,6 @@ void xen_force_evtchn_callback(void)
>>
>> static void __init __xen_init_IRQ(void)
>> {
>> -#ifdef CONFIG_X86_64
>> int i;
>>
>> /* Create identity vector->irq map */
>> @@ -31,7 +30,6 @@ static void __init __xen_init_IRQ(void)
>> for_each_possible_cpu(cpu)
>> per_cpu(vector_irq, cpu)[i] = i;
>> }
>> -#endif /* CONFIG_X86_64 */
>>
>> xen_init_IRQ();
>> }
>>


Rusty,
can you check tip/master with lguest? wonder you need to do sth for lguest too.
we are making 32 bit support per_cpu vector like 64 bit

also alok, can you check vmi etc...

Thanks

Yinghai Lu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/