Re: [PATCH] atl1: disable TSO by default

[Herbert Xu]

Jay Cliburn <jacliburn@xxxxxxxxxxxxx> wrote:
> 
> diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
> index e6a7bb7..e23ce77 100644
> --- a/drivers/net/atlx/atl1.c
> +++ b/drivers/net/atlx/atl1.c
> @@ -3022,7 +3022,6 @@ static int __devinit atl1_probe(struct pci_dev *pdev,
>        netdev->features = NETIF_F_HW_CSUM;
>        netdev->features |= NETIF_F_SG;
>        netdev->features |= (NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX);
> -       netdev->features |= NETIF_F_TSO;
>        netdev->features |= NETIF_F_LLTX;

Another new driver using LLTX, this is not good when we're trying
to get rid of it.

Perhaps we could just kill it by ignoring the LLTX flag and always
grabbing the xmit lock.  That should be safe as long as none of these
drivers grab the xmit lock within their private locks.

LLTX drivers will be a tad slower, but that should encourage them
to stop using it :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/