Re: [PATCH 08/10] PPS: serial clients support.

From: Alan Cox
Date: Tue Aug 19 2008 - 18:15:53 EST


> +static void pps_tty_dcd_change(struct uart_port *port, unsigned int status,
> + struct timespec *ts)
> +{
> + int id = (int) port->info->port.tty->disc_data;

See you really do want to pass struct tty * upwards anyway 8)


Rest of this looks good. Maybe pps ldisc belongs in the n_tty file in the
end but again that can be twiddled with after the merge.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/