Re: [PATCH 2/5] ide: ->ide_dma_clear_irq() -> ->clear_irq()

[Sergei Shtylyov]

Hello.

Bartlomiej Zolnierkiewicz wrote:

> * Rename ->ide_dma_clear_irq method to ->clear_irq
>   and move it from ide_hwif_t to struct ide_port_ops.
>
> * Move ->waiting_for_dma check inside ->clear_irq method.
>
> * Move ->dma_base check inside ->clear_irq method.
>
> piix.c:
> * Add ich_port_ops and remove init_hwif_ich() wrapper.
>
> There should be no functional changes caused by this patch.
>   

  Good. I think it's worth implementing this method in at least 
cmd64x.c which actually reads the IDE interrupt latch bits (independent 
from the DMA interrupt status) in the dma_test_irq() methods but never 
clears them, so the latches may reflect a non-current state of the IDE 
interrupt...
  It may also be worth considering turning this method into 
test-and-clear, so that we can get the actual IDE interrupt state on the 
chips that implement this...

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/