Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces

[Matthew Garrett]

On Tue, Aug 19, 2008 at 10:18:29PM -0300, Henrique de Moraes Holschuh wrote:

> 1. If the event has no bearing on compulsory hardware state changes (i.e.
> the hardware won't change state by itself when the event happens, it is
> really just reporting a simple key press that will do nothing by itself),
> you just report the key as an event.

Yes. That's all I do.

> 2. If the hardware/firmware *ALSO* compulsory changes the rfkill state (i.e.
> the event also means the real rfkill controller state probably changed), you
> take the opportunity to do a forced immediate state poll and
> rfkill_force_state() the new state.

The firmware does not perform any compulsory change.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/