Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth togglingthrough rfkill (v5)

From: Philip Langdale
Date: Tue Aug 19 2008 - 23:02:51 EST


Henrique de Moraes Holschuh wrote:
+ toshiba_acpi.rfk_dev->state = RFKILL_STATE_OFF;

Where did that RFKILL_STATE_OFF came from ? :-) Just get rid of it, you
override it four statements later anyway...

Left over from the first iteration. Now removed and diff updated.


Other than that, the rfkill bits look fine to me.


Thanks. Anyone else care to voice an opinion? Should this go in through
wireless-testing then?

--phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/