Re: [PATCH] fix adjtimex() freq return error

From: Roman Zippel
Date: Wed Aug 20 2008 - 08:05:17 EST


Hi,

On Tue, 19 Aug 2008, Andrew Morton wrote:

> On Tue, 19 Aug 2008 19:29:06 -0700 john stultz <johnstul@xxxxxxxxxx> wrote:
>
> > Martin Ziegler reported a bug in adjtimex(), where odd positive
> > frequencies are reduced by 1 while negative values are correct.

To put this in perspective one should also know that 1 here means an error
of 2^-16ppm or less than 0.02nsec.
When I wrote this code, I noticed that the rounding isn't perfect, but
OTOH the error is so small that it can't have any practical relevance.
AFAIC the old code is fine as is.

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/