Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB

[Jaya Kumar]

On Wed, Aug 20, 2008 at 3:50 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 20 Aug 2008 20:40:54 +0100
> Ian Campbell <ijc@xxxxxxxxxxxxxx> wrote:
>
>> On Wed, 2008-08-20 at 12:30 -0700, Andrew Morton wrote:
>> > On Wed, 20 Aug 2008 19:57:53 +0100 Ian Campbell <ijc@xxxxxxxxxxxxxx>
>> > wrote:
>> >     }
>> > > +#ifdef CONFIG_FB_DEFERRED_IO
>> > > + if (info->fbdefio)
>> > > +         fb_deferred_io_open(info, inode, file);
>> > > +#endif
>> >
>> > eww, hacky, but drivers/video/fbmem.c already got hacky:
>> >
>> > #ifdef CONFIG_FB_DEFERRED_IO
>> >         .fsync =        fb_deferred_io_fsync,
>> > #endif
>> >
>> > so it's not an original sin.
>>
>> That's what I figured.
>
> A better implementation would be to change the fb_ops.fb_open()
> arguments, or to add fb_ops.fb_open2() with the file*.
>
> Also, that .fsync thing should be done properly via a new fb_ops.fb_fsync().
>
> But neither are pressing issues and I guess can be left for when Jaya
> is feeling bored?


hehe, i haven't bene bored ever since i started playing with linux. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/