Re: [PATCH] ATA Kconfig cleanup: sort the driver list and modify some text

[Grant Coady]

On Thu, 21 Aug 2008 01:27:52 +0200, Krzysztof Halasa <khc@xxxxxxxxx> wrote:

>Grant Coady <grant_lkml@xxxxxxxxxxx> writes:
>
>> --- linux-2.6.27-rc3a/drivers/ata/Kconfig	2008-07-14 07:51:29.000000000 +1000
>> +++ linux-2.6.27-rc3c/drivers/ata/Kconfig	2008-08-18 11:29:20.871422237 +1000
>> @@ -3,7 +3,7 @@
>>  #
>>  
>>  menuconfig ATA
>> -	tristate "Serial ATA (prod) and Parallel ATA (experimental) drivers"
>> +	tristate "Serial ATA and Parallel ATA (SATA/PATA) drivers"
>
>I don't think so. Maybe
>> +	tristate "Serial ATA (SATA) and Parallel ATA (PATA) drivers"

Yes, I think that's what I had before.
>
>>  config ATA_SFF
>>  	bool "ATA SFF support"
>>  	default y
>> @@ -93,123 +93,15 @@
>>  
>>  if ATA_SFF
>
>How the user compiling the kernel knows what ATA_SFF stands for?

They read the help text :)  

Perhaps add (legacy drivers) to the SFF menu item?  But that's not 
quite true either.  

>Why not "select ATA_SFF" instead (when any driver using this is
>selected)?

Because then the driver list is always visible?  I'll try it next time 
I look at the patch (when -rc4 is out), I think cleanups wait for next 
merge window anyway.  Perhaps I'll offer both alternatives and see which 
gets picked up.

Besides, I don't like the way select locks in stuff at the moment, means 
you have to turn off every option to get rid of the forced select option 
 -- I'd rather see turning off a 'select'ed item drop all of its 
dependencies.  

Cheers,
Grant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/