Re: Bug: "bad unlock balance detected" 2.6.27-rc3-next-20080820

From: Vegard Nossum
Date: Thu Aug 21 2008 - 04:20:34 EST


On Thu, Aug 21, 2008 at 10:10 AM, Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:
> On Thu, Aug 21, 2008 at 9:04 AM, jay kumar <jaykumarks@xxxxxxxxx> wrote:
>> While testing 2.6.27-rc3-next-20080820 , i observed this "BUG:bad
>> unlock balance detected" during boot time
>>
> Thanks for the report. The error comes from
>
> commit d9a939fb80ef390b78b3c801f668bd1e35ebc970
> Author: David Howells <dhowells@xxxxxxxxxx>
> Date: Thu Aug 7 20:02:20 2008 +1000
>
> CRED: Make execve() take advantage of copy-on-write credentials
>
> (Added to Cc. I guess it's also nice to Cc linux-next on errors in -next code.)
>
> I couldn't reproduce your original failure, but I've attempted to fix
> it by reordering the mutex unlock and bprm free and removing the
> extraneous unlock (see attached patch; it boots for me without
> errors).

Actually, I was able to reproduce the original issue after all. And
the patch fixed it for me. Please review :-)


Vegard

--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/