Re: apic version warning.

From: Ingo Molnar
Date: Thu Aug 21 2008 - 04:54:44 EST



* Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:

> after following patch,
>
> commit 1b313f4a6d7bee7b2c034b3f1e203bc360a71cca
> Author: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> Date: Mon Aug 18 20:45:57 2008 +0400
>
> x86: apic - generic_processor_info
>
> - use physid_set instead of phys_cpu and physids_or
> - set phys_cpu_present_map bit AFTER check for allowed
> number of processors
> - add checking for APIC valid version in 64bit mode
> (mostly not needed but added for merging purpose)
> - add apic_version definition for 64bit mode which
> is used now
>
> we are getting warning for acpi path on 64 bit system
>
> please add #ifdef for that.
> actually, 64 bit doesn't use that apic_version[]
>
>
> or using following patch?

yeah, i like that patch better - the more symmetry the better. Applied
to tip/x86/apic.

Ingo

--------------->