Re: [RFC][PATCH 2/2] quicklist shouldn't be proportional to # of CPUs

From: KOSAKI Motohiro
Date: Thu Aug 21 2008 - 06:23:22 EST



Sorry, following patch is crap.
please forget it.

I'll respin it soon.


>
> ---
> mm/quicklist.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> Index: b/mm/quicklist.c
> ===================================================================
> --- a/mm/quicklist.c
> +++ b/mm/quicklist.c
> @@ -26,7 +26,10 @@ DEFINE_PER_CPU(struct quicklist, quickli
> static unsigned long max_pages(unsigned long min_pages)
> {
> unsigned long node_free_pages, max;
> - struct zone *zones = NODE_DATA(numa_node_id())->node_zones;
> + int node = numa_node_id();
> + struct zone *zones = NODE_DATA(node)->node_zones;
> + int num_cpus_on_node;
> + node_to_cpumask_ptr(cpumask_on_node, node);
>
> node_free_pages =
> #ifdef CONFIG_ZONE_DMA
> @@ -38,6 +41,10 @@ static unsigned long max_pages(unsigned
> zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES);
>
> max = node_free_pages / FRACTION_OF_NODE_MEM;
> +
> + num_cpus_on_node = cpus_weight_nr(*cpumask_on_node);
> + max /= num_cpus_on_node;
> +
> return max(max, min_pages);
> }





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/