Re: [PATCH] x86: {reverve,free}_memtype() take a physical address

From: Rene Herman
Date: Thu Aug 21 2008 - 18:25:59 EST


On 22-08-08 00:16, Pallipadi, Venkatesh wrote:

Yes. Noticed that too and sent a patch here for x86/tip.

http://www.ussg.iu.edu/hypermail/linux/kernel/0808.2/2270.html

It is not very critical as it sounds as only set_memory_uc sets PAT
bits for RAM pages. Most other users (devmem mmap, ioramep, pci)
set PAT bits on the reserved memory. And there will not be conflicts
across RAM and reserveed regions. Regardless, this was a stupid
bug that we had missed earlier.

And unfortunately I don't think the above fully fixes it for AGP. __pa() gets the real physical address and the memtypes should be on the GART remapped physical addresses it seems.

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/