Re: 2.6.27-rc4: 90% system time because of khubd, unable to reboot

[Alan Stern]

On Fri, 22 Aug 2008, Andrey Borzenkov wrote:

> > > reverting 38b375d9610e2467cb793a84d17c6f65e44cdb39 fixed it
> > > 
> > 
> > ... that is:
> > 
> > commit 38b375d9610e2467cb793a84d17c6f65e44cdb39
> > Author: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Date:   Mon Jul 21 09:56:26 2008 -0400
> > 
> >     USB: OHCI: fix system hang caused by earlier patch
> > 
> >     Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> >     Tested by: Andrey Borzenkov <arvidjaar@xxxxxxx>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > 
> > so it apparently used to work for you at that time.  What gives?
> > 
> 
> Well, you should not commit a fix without commiting code that has been
> fixed first :)

Actually the code to be fixed _was_ committed first -- but then it was 
reverted before the fix was accepted, so the fix was merged without it.

My advice is not to worry about it.  That code has been sent once again
to Linus -- it's not merged yet but presumably it will be soon.  
Certainly before 2.6.27-rc5 appears.

On the other hand, I still have to wonder how the fix could have caused
your problem without the original patch in place.  The fix itself
should have been totally innocuous.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/