Re: latest -git: WARNING: at arch/x86/kernel/ipi.c:123 send_IPI_mask_bitmask+0xc3/0xe0()

From: Jeremy Fitzhardinge
Date: Sat Aug 23 2008 - 02:42:35 EST


H. Peter Anvin wrote:
> Well, smp_call_function_single already does all necessary locking; it
> makes more sense for it to check that what it's about to call still
> exists while inside the lock, instead of requiring the higher layers
> to guarantee that cannot happen on it. This is simply a matter of the
> cost of checking at this point being quite low.

It does, already doesn't it? Hm, smp_call_function_mask() ands the
provided mask with the online mask, but it doesn't look like
smp_call_function_single() does the equivalent.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/