Re: Fix oops in acer_wmi

From: Carlos Corbacho
Date: Sat Aug 23 2008 - 21:20:27 EST


On Saturday 23 August 2008 22:05:09 Arjan van de Ven wrote:
> this is due to a null pointer due to a misordered initialization...
> when the DMI quirks get run, the "interface" variable might not have been
> initialized. The patch below 1) prevents the oops and 2) runs the quirks
> again after all the "interface" initialization has completed.

Acked-by: Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>

(Although this patch is missing an SOB from yourself).

> This oops is new in 2.6.27-rc and thus counts as a regression...

NAK - I disagree. This has been broken since day one, there is nothing
special, as far as I am concerned, about 2.6.27 in this respect.

(If this is showing up that much in kerneloops.org, then I would recommend
CC'ing it to stable).

-Carlos
--
E-Mail: carlos@xxxxxxxxxxxxxxxxxxx
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/