Re: [PATCH] exit signals: use of uninitialized field notify_count

[Oleg Nesterov]

On 08/27, Ingo Molnar wrote:
> 
> * Steve VanDeBogart <vandebo-lkml@xxxxxxxxxxx> wrote:
> 
> > task->signal->notify_count is only initialized if
> > task->signal->group_exit_task is not NULL.  Reorder a conditional so
> > that uninitialised memory is not used.  Found by Valgrind.
> >
> > Signed-off-by: Steve VanDeBogart <vandebo-lkml@xxxxxxxxxxx>
> 
> Applied the commit below to tip/core/urgent, thanks. Roland/Oleg, do you 
> concur with the fix?

Inho, very nice cleanup.

Minor comment. As Roland pointed out, it makes sense to initialize
the whole signal_struct explicitely, perhaps copy_signal() should
just use zalloc. In that case we don't need to check ->group_exit_task
at all, the same for __exit_signal().

Thanks Steve! and what do you think about the above?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/