Re: [PATCH] kmemtrace: SLUB hooks for caller-tracking functions.

[Pekka Enberg]

Eduard - Gabriel Munteanu wrote:
> On Sun, Aug 31, 2008 at 05:35:40PM +0300, Pekka Enberg wrote:
> > Eduard - Gabriel Munteanu wrote:
> > > This patch adds kmemtrace hooks for __kmalloc_track_caller() and
> > > __kmalloc_node_track_caller(). Currently, they set the call site pointer
> > > to the value recieved as a parameter. (This could change if we implement
> > > stack trace exporting in kmemtrace.)
> > > Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@xxxxxxxxxxx>
> > Applied. I had to do some manual tweaking, so can you please double-check 
> > the result:
> >
> > http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=b9f1ecc6428f0ba391845b2ac7df8618da287e4f
> >
> > Thanks!
>
> Looks fine to me. However, you can now remove the casts to unsigned long
> from 'caller', i.e. "s/(unsigned long) caller/caller/g"

Fixed, thanks!

http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=0fae99540ebb53e0507f2bd6e119bede94e84f77
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/