Re: [PATCH] Remove stop_machine during module load

[Andi Kleen]

On Mon, Sep 01, 2008 at 05:02:00PM +1000, Rusty Russell wrote:
> On Saturday 30 August 2008 05:17:34 Andi Kleen wrote:
> > Remove stop_machine during module load
> >
> > module loading currently does a stop_machine on each module load to insert
> > the module into the global module lists.  Especially on larger systems this
> > can be quite expensive.
> 
> Thanks Andi, but doesn't this mean that we should be doing list_for_each_rcu 
> in all the kallsyms readers?

Yes I did that in v2. But only for the ones that don't hold modules_mutex
anyways. Also I found that print_modules() does not always disable 
preemption.

-Andi

-- 
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/