Re: [PATCH 0/2] x86: fix memory leaks when doing CPU hotplug

[Andreas Herrmann]

On Mon, Aug 11, 2008 at 09:40:15PM +0200, Ingo Molnar wrote:
> 
> * Andreas Herrmann <andreas.herrmann3@xxxxxxx> wrote:
> 
> > Following patches fix two memory leaks with CPU hotplug. Some per CPU 
> > data is allocated each time a CPU is set online. But this space is 
> > never freed.
> > 
> > Usually this memory leak is not a big deal (for normal CPU hotplug 
> > usage). But during stress tests with lots of CPU offline/online cycles 
> > this really matters.
> > 
> > The entire leak is 40K (10 pages) for each offline/online cycle per 
> > CPU.  I've verified both fixes performing more than 90000 CPU 
> > offline/online cycles.
> 
> applied to tip/x86/core, thanks Andreas.
> 
> > This is not a regression but I think it's still 2.6.27 material. 
> > Please apply.
> 
> it's tricky code so i guess it's best to let it cook in tip/master a 
> bit. If it does not show up upstream by say -rc4 time could you please 
> ping us about it?

Ping!

It's -rc5 time and

b55793f7528ce1b73c25b3ac8a86a6cda2a0f9a4 (x86: cpu_init(): fix memory leak when using CPU hotplug)
49800efcb17afdf973f33e8aa8807b7f83993cc6 (x86: pda_init(): fix memory leak when using CPU hotplug)

are in tip/master but not yet upstream.


Regards,

Andreas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/